Markdown: don't allow space between parts of a link #59977
Merged
+0
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Markdown, links are written as `[desc](URL)`, and no space is allowed between `]` and `(`. However, Julia's Markdown parser explicitly accepted it (not clear why). This may break links in a few package manuals, but the fix will be easy in each case (just remove the extra spaces). But being more consistent with most (all??) other Markdown implementations seems more important to me; it is very surprising when one copies basic Markdown that works fine elsewhere into a Julia package manual and it suddenly is treated completely differently. Resolves JuliaDocs/Documenter.jl#2681
tecosaur
approved these changes
Nov 7, 2025
Member
tecosaur
left a comment
tecosaur
left a comment
There was a problem hiding this comment.
This seems eminently sane to me.
Member
|
The test failure is in GC, and clearly spurious. |
fingolfin
added
backport 1.13
backport 1.12
KristofferC
pushed a commit
that referenced
this pull request
Nov 8, 2025
In Markdown, links are written as `[desc](URL)`, and no space is allowed between `]` and `(`. However, Julia's Markdown parser explicitly accepted it (not clear why). This may break links in a few package manuals, but the fix will be easy in each case (just remove the extra spaces). But being more consistent with most (all??) other Markdown implementations seems more important to me; it is very surprising when one copies basic Markdown that works fine elsewhere into a Julia package manual and it suddenly is treated completely differently. Resolves JuliaDocs/Documenter.jl#2681 (cherry picked from commit fe30573)
KristofferC
pushed a commit
that referenced
this pull request
Nov 8, 2025
In Markdown, links are written as `[desc](URL)`, and no space is allowed between `]` and `(`. However, Julia's Markdown parser explicitly accepted it (not clear why). This may break links in a few package manuals, but the fix will be easy in each case (just remove the extra spaces). But being more consistent with most (all??) other Markdown implementations seems more important to me; it is very surprising when one copies basic Markdown that works fine elsewhere into a Julia package manual and it suddenly is treated completely differently. Resolves JuliaDocs/Documenter.jl#2681 (cherry picked from commit fe30573)
KristofferC
pushed a commit
that referenced
this pull request
Nov 10, 2025
In Markdown, links are written as `[desc](URL)`, and no space is allowed between `]` and `(`. However, Julia's Markdown parser explicitly accepted it (not clear why). This may break links in a few package manuals, but the fix will be easy in each case (just remove the extra spaces). But being more consistent with most (all??) other Markdown implementations seems more important to me; it is very surprising when one copies basic Markdown that works fine elsewhere into a Julia package manual and it suddenly is treated completely differently. Resolves JuliaDocs/Documenter.jl#2681 (cherry picked from commit fe30573)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Markdown, links are written as
[desc](URL), and no space is allowed between]and(. However, Julia's Markdown parser explicitly accepted it (not clear why).This may break links in a few package manuals, but the fix will be easy in each case (just remove the extra spaces).
But being more consistent with most (all??) other Markdown implementations seems more important to me; it is very surprising when one copies basic Markdown that works fine elsewhere into a Julia package manual and it suddenly is treated completely differently.
Resolves JuliaDocs/Documenter.jl#2538
Resolves JuliaDocs/Documenter.jl#2681